Skip to content

Set resource_name in .tx/config files to preserve resource naming behavior prior to 2.1.0 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

Set resource_name in .tx/config files to preserve resource naming behavior prior to 2.1.0 #90

merged 2 commits into from
Oct 3, 2023

Conversation

@jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented Jun 14, 2023 •
edited
Loading

closes #88

@jpmckinney jpmckinney mentioned this pull request Jun 14, 2023
Closed
m-aciek
m-aciek reviewed Jun 14, 2023
View reviewed changes
Copy link

@m-aciek m-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a test?

@jpmckinney
Copy link
Contributor Author

@m-aciek I've added a test and updated my commit with the suggestion.

m-aciek
m-aciek approved these changes Jun 14, 2023
View reviewed changes
Copy link

@m-aciek m-aciek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@rffontenelle
Copy link
Contributor

rffontenelle commented Jun 19, 2023 •
edited
Loading

Confirmed it is working. It successfully adds "resource_name" field to each resource entry and pushing to Transifex sends the expected resource name. Thanks for that!

Can you also add a Feature entry to CHANGES file?

@jpmckinney
Copy link
Contributor Author

I've added an entry :)

@rffontenelle rffontenelle mentioned this pull request Jun 20, 2023
Draft
@jpmckinney
Copy link
Contributor Author

Is there anything blocking a merge?

@rffontenelle rffontenelle mentioned this pull request Oct 3, 2023
Closed
@AA-Turner AA-Turner merged commit 463f65f into sphinx-doc:master Oct 3, 2023
@AA-Turner
Copy link
Member

@jpmckinney tests failed on master, please could you provide a fix? Otherwise we'll need to revert.

A

@jpmckinney
Copy link
Contributor Author

I'll look into it!

@jpmckinney
Copy link
Contributor Author

I'm unable to reproduce and I installed the same versions of packages as listed by pip freeze in the workflow.

@jpmckinney
Copy link
Contributor Author

jpmckinney commented Oct 5, 2023 •
edited
Loading

Aha, something changed in tx between 1.6.7 and 1.6.10. Looks like failures start with 1.6.8.

@jpmckinney
Copy link
Contributor Author

Okay, tx just changed the whitespace alignment: #96

@jpmckinney jpmckinney mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rffontenelle rffontenelle rffontenelle approved these changes

@m-aciek m-aciek m-aciek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transifex's tx client seems to have changed behavior for resource naming

4 participants

@jpmckinney @rffontenelle @AA-Turner @m-aciek