Allow classes derived from Extension #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a property allows /Extension/Extension as the type, then it must allow any class derived from Extension. Since this could be any user defined type, assume that any unknown class type is derived from Extension. Or put another way, disallow any type that is known to not derive from Extension, but allow anything else
This was referenced Apr 22, 2025
zvr
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a property allows /Extension/Extension as the type, then it must allow any class derived from Extension. Since this could be any user defined type, assume that any unknown class type is derived from Extension.
Or put another way, disallow any type that is known to not derive from Extension, but allow anything else