Skip to content

Conversation

@goneall
Copy link
Member

@goneall goneall commented Feb 3, 2025

Fixes #294

Also adds an example and unit test to help check example code

Fixes #294

Also adds an example and unit test to help check example code
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestions.

goneall and others added 2 commits February 24, 2025 19:15
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
@goneall
Copy link
Member Author

goneall commented Feb 25, 2025

Thanks @bact - I added your recommended changes

@goneall goneall merged commit 84d2aee into master Feb 25, 2025
1 check passed
@goneall goneall deleted the issue294 branch February 25, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The code examples contain errors

2 participants