Implementation of SPDX version 3.0.0 spec #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. Change the storage interface to use a PropertyDescriptor type which includes both a property name and a namespace. This prevents property name collisions which will occur in the SPDX v3 model update. To update any code which uses the storage interface, change the property name to PropertyDescriptor for all calls to the interface which used propertyName. The constants have been updated to use the PropertyDescriptor type which should minimize the amount of change. Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Still many unit tests are failing - but at least it compiles. Change the storage interface to use object URI's - getting rid of the requirement for SPDX document containers - causes a major redesign Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
All unit tests pass except compares Signed-off-by: Gary O'Neall <[email protected]>
Still some unit test failures in compare Signed-off-by: Gary O'Neall <[email protected]>
All unit tests now pass Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Unit tests are currently placeholders Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Now compiles - unit test are currently failing Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Change ModelCopyManager to remove type parameter Signed-off-by: Gary O'Neall <[email protected]>
Implementation is not complete - this is an intermediate checkin Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Required an update of the SPDX model 3 which renamed a few fields. There are 2 to the treatment of the external licenses: - Uses a ID map rather than the SPDX document as a parameter - Passes in the appropriate types Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Also fixes unit tests broken by the move of the compatible storage manager Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
After attempting to fix - fixed several, but many missing remain Signed-off-by: Gary O'Neall <[email protected]>
|
@pmonks - This is probably way to big of a pull request to review, but if you're available for a quick sanity check - I plan on merging and cutting an "Alpha" release of the library this week. The upgrade documentation describes some of the changes. |
|
@goneall I'm on vacation with limited cell / wifi until Sept 11th, but will be back then. Maybe go ahead with the alpha (which I can also test when I get back in my own code), and I'll prioritise a review as soon as I can? |
@pmonks - I'll go ahead with the Alpha. I'll also sign up a couple other users of the library for a review after the alpha release. Enjoy your vacation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a HUGE pull request with a lot of breaking changes.
There are a number of additional dependent libraries which I plan to move to the SPDX github repo in the near future, so this is currently marked as a draft.
If you do want to attempt to compile and test, the additional repos are at github.com/goneall.
I'll update once the other repos are moved over.