NumberFormatException when parsing SPDXID larger than MaxInt

[raleigh04]

When faced with with an SPDXID larger than java's max int, tools-java throws a NumberFormatException:

Example:

"SPDXID": "SPDXRef-6996049013223528",

Throws:

Error converting: Error converting SPDX file: class java.lang.NumberFormatException For input string: "6996049013223528"

[goneall]

@raleigh04 Could you provide the stack trace for the error and/or an SPDX file that duplicates the problem?

[raleigh04]

Hey @goneall ! Thanks for the quick reply!

The jar doesn't output a trace, just that error message.

platform-internal.json.zip

[goneall]

Thanks @raleigh04 for the additional info. The error is occurring the Spdx-Java-Library:

Spdx-Java-Library/src/main/java/org/spdx/storage/simple/InMemSpdxStore.java

Line 177 in c8a0e16

int num = Integer.parseInt(strNum);

It looks like a bit of a design flaw in using an integer for generating new SPDX ID's. To make sure generated ID's are unique, the library sets the next integer to be the number after the largest integer following the SPDXRef-.

In looking at the attached JSON file, it looks like the ID's in the file are a string of hex digits which likely includes all numbers in some fields which resets the counter beyond the max int.

To fix this, we could prefix the generated ID's with text likely not to be found in other SPDX documents (e.g. SPDXRef-genrtd[num] where [num] is the counter value).

A quick fix would be to change this to a long, but that could also

[goneall]

Transferring this issue to the SPDX java library

[goneall]

@raleigh04 This will be fixed in the next release.

You should be able to work around this issue by doing a search/replace of SPDXRef- with SPDXRef-x where x is any non-numeric character.

[raleigh04]

Thank you!