[pull] 16.x.x from graphql:16.x.x #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Added missing documentation * Added links to GraphQL spec
Co-authored-by: Ivan Goncharov <[email protected]>
Co-authored-by: Ivan Goncharov <[email protected]>
Co-authored-by: Ivan Goncharov <[email protected]>
Co-authored-by: Saihajpreet Singh <[email protected]> Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Jovi De Croock <[email protected]>
Relevant to these PRs: - #4380 - #4381 - #4382 - #4383 - #4391 In general this content was excellent - thanks @sarahxsanders! - but I wanted to add a few minor updates. I've included comments in a few places with reasoning. If this PR is too much to review all at once, I'm happy to break it up as I did review of each PR separately.
Co-authored-by: Benjie <[email protected]>
Adds guide "Using Directives in GraphQL.js"
Adds "Nullability in GraphQL.js" guide
Guide for subscriptions
Adds page on authorization strategies, right after authentication/middleware page Also adds a "Before you start" section about using ESM syntax JS code snippets --------- Co-authored-by: Jovi De Croock <[email protected]>
Updates "Going to Production" guide to cover a larger scope. The goal is to cover most bases on what devs should consider before deploying to production. I also added a checklist. --------- Co-authored-by: Benjie <[email protected]>
Adds guide on caching strategies --------- Co-authored-by: Benjie <[email protected]>
adds guide on Scaling your API, covering monoliths, schema stitching, and federation --------- Co-authored-by: Benjie <[email protected]>
Expands on #4398 by recommending the trusted documents pattern which 90+% of GraphQL users should be using.
Adds new guide: Type Generation for GraphQL Servers This is a part of the effort to expand GraphQL.js documentation --------- Co-authored-by: Eddy Nguyen <[email protected]> Co-authored-by: Benjie <[email protected]>
Adds guide "Operation Complexity Controls" --------- Co-authored-by: Benjie <[email protected]>
Editorial on #4393
This PR has some cleanup tasks: - Reorganized the information architecture a bit so that sections flow better - Fixed broken links - Fixed a code snippet that wasn't closed off/bleeding into a section - Updated auth strategy guide w/ callouts for not using resolver auth in production per @benjie request Please let me know if there are any other tweaks I can include! --------- Co-authored-by: Benjie <[email protected]> Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Benjie <[email protected]>
) The example shows graphql implementation, where the "root" is by mistake put as string as part of the schema definition instead being a native js const BEFORE (root is undefined and wongly put into the schema itself):  AFTER (root correctly defined outside of the schema): 
The fourth permutation was removed in #2957 See #4466 --------- Co-authored-by: Yaacov Rydzinski <[email protected]>
per github/gitignore@ca05a4d this file has been moved this is causing this error: https://github.com/graphql/graphql-js/actions/runs/17255990646/job/48967789469?pr=4478: ``` Run git clone --depth 1 https://github.com/github/gitignore.git git clone --depth 1 https://github.com/github/gitignore.git rm gitignore/Global/ModelSim.gitignore rm gitignore/Global/Images.gitignore cat gitignore/Node.gitignore gitignore/Global/*.gitignore > all.gitignore IGNORED_FILES=$(git ls-files --cached --ignored --exclude-from=all.gitignore) if [[ "$IGNORED_FILES" != "" ]]; then echo -e "::error::Please remove these files:\n$IGNORED_FILES" | sed -z 's/\n/%0A/g' exit 1 fi shell: /usr/bin/bash -e {0} Cloning into 'gitignore'... rm: cannot remove 'gitignore/Global/ModelSim.gitignore': No such file or directory Error: Process completed with exit code 1. ``` --------- Co-authored-by: Jovi De Croock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )