Remove FunctionProxy#count #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code depends on a SQLite API which is deprecated, sqlite3_aggregate_count. In addition, the present implementation is broken (@driver is always nil). Related: sparklemotion#164.
|
@alexcwatt Thanks! I'll look at the CI failure. |
|
CI was a flake. This looks good to me, after looking at the history it seems like this should have been removed in aaa74eb back in (gulp) 2010. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code depends on a SQLite API which is deprecated,
sqlite3_aggregate_count(docs). In addition, the present implementation is broken (@driveris always nil). Related: #164.Note to reviewers
This check failed and appears unrelated to this code change.