Intern column names so we always get the same string #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
force-pushed
the
intern-column-names
branch
2 times, most recently
from
c503ba4 to
bb63f86
Compare
tenderlove
force-pushed
the
intern-column-names
branch
from
b6dc749 to
149658c
Compare
When we get column names back from the database, it's very common to always return the same strings. This patch uses Ruby's "interned string" API so that we're always getting the same string objects back from the database. Fixes: #155
tenderlove
force-pushed
the
intern-column-names
branch
from
5c5264a to
dd70e03
Compare
eregon
reviewed
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get column names back from the database, it's very common to always return the same strings. This patch uses Ruby's "interned string" API so that we're always getting the same string objects back from the database.
Fixes: #155