Don't mandate dl functions for the extention build #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sqlite3-ruby doesn't use dl functions, nor does extconf compile sqlite3 sources, which possibly makes use of them. So mandating dl functions in extconf is wrong and breaks the build on Windows. Fixes sparklemotion#250 . This pertly reverts commit f4ffec2.
larskanis
changed the title
This was referenced Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sqlite3-ruby doesn't use dl functions, nor does extconf compile sqlite3 sources, which possibly makes use of them. So mandating dl functions in extconf is wrong and breaks the build on Windows.
Fixes #250 .
This reverts commit f4ffec2.