rake tasks executed twice (Ruby 1.9.2)

[FND]

It appears that sqlite3 leads to rake tasks being executed twice:

$ cd /tmp
$ rails new foo
$ cd foo
$ bundle install

$ bundle exec rake db:create
db/test.sqlite3 already exists
db/development.sqlite3 already exists
$ bundle exec rake db:create
db/test.sqlite3 already exists
db/development.sqlite3 already exists
db/test.sqlite3 already exists
db/development.sqlite3 already exists

The same doesn't happen when disabling sqlite3:

$ sed "s/gem 'sqlite3'/gem 'mysql2'/" -i Gemfile
$ bundle install
$ $EDITOR config/database.yml # set up MySQL with database name "tmp"

$ bundle exec rake db:create
db/test.sqlite3 already exists
db/test.sqlite3 already exists
$ bundle exec rake db:create
db/test.sqlite3 already exists
db/test.sqlite3 already exists
tmp already exists

We've confirmed this on Ubuntu and OS X using Ruby 1.9.2 (both p180 and p290, via RVM) - however, it appears everything works fine with Ruby 1.8.7.

[youngbrioche]

+1

[luislavena]

Hello, this has nothing to do with sqlite3 but is your Rails application and Rake.

sqlite3 provides a DB adapter, you can see that other tasks under Rails suffer from the same.

[FND]

Thanks for your quick response!

this [...] is your Rails application and Rake

Can you clarify this?
The reduced test case above was meant to eliminate application-specific variables (although, granted, Rails itself is a pretty big factor).

sqlite3 provides a DB adapter, you can see that other tasks under Rails suffer from the same

So this is a known issue with Rails then? (FWIW, I had googled - unsuccessfully - before reporting this issue.)

What struck me as weird was that disabling sqlite3 made the issue disappear.

[luislavena]

Both db/test.sqlite3 and db/development.sqlite3 are created when ActiveRecord connects with SQLite3.

Now, Rails does this:

https://github.com/rails/rails/blob/v3.0.9/activerecord/lib/active_record/railties/databases.rake#L29-36

db:create task depends on load_config task, which calls create_database for each of the config settings found that are local (dev, test and production unless you change it)

https://github.com/rails/rails/blob/v3.0.9/activerecord/lib/active_record/railties/databases.rake#L24

Then, inside create_database, which is the second time is called, it determine that the sqlite3 files already exist:

https://github.com/rails/rails/blob/v3.0.9/activerecord/lib/active_record/railties/databases.rake#L40-57

And outputs already exists

Does that proves this has nothing to do with SQLite3 project?

[FND]

Thank you for this detailed explanation!

I'll keep digging - hopefully we'll be able to identify the true culprit and submit a patch to the respective project.

[FND]

FWIW, it turns out this issue is specific to our application after all - the db:create test case was a red herring (those duplicate "already exists" messages stem from two different lines within create_database).

[luislavena]

I'll keep digging - hopefully we'll be able to identify the true culprit and submit a patch to the respective project.

The culprit is that create_database is called twice, once in load_config when local_database? executes the block and the other in the db:create task itself.

This happens for any database that has host to 127.0.0.1 or localhost (host is blank, which is the case of SQLite3)

I think the failure is in load_config, is beyond it's role, it should be only loading the configuration and allowing the real create task deal with it.

But that is my personal thought about it.

Cheers.