Add imshow() #7
Merged
Add imshow() #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigapod
approved these changes
Jun 3, 2025
Mostly just for compatibility with existing OpenCV code
Based on feedback in #7
Needed for new ST7789 implementation to convert other dtypes
Create helper functions for imshow() (could move these to a generic interface class for other display drivers to take advantage of) Move machine dependency from example to display driver Add extra checks for edge cases Remove unused functions and arguments Add clear() method Fix imshow() with float images to clip instead of wrap the range 0-1 Other minor optimizations
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of
imshow().This is a minor tweak to the standard
imshow()API. Instead of passing a string for a window, the user passes an object that implements its ownimshow()function that actually displays the image.A sample display driver is included, plus an example showing fairly minimal code for a user to get started with MicroPython-OpenCV.