Skip to content

Feature/build release #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 30, 2025
Merged

Conversation

malcolm-sparkfun
Copy link
Contributor

Added necessary build steps to generate a release artifact "firmware.uf2" on release. This image contains the firmware and the software in the "examples" directory.

@malcolm-sparkfun malcolm-sparkfun changed the base branch from main to features_for_launch July 22, 2025 15:50
@sfe-SparkFro sfe-SparkFro self-requested a review July 22, 2025 16:17
Copy link
Collaborator

@sfe-SparkFro sfe-SparkFro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person, but documenting here:

Change the frozen examples to only be added to the file system on first boot, not every boot.

Update - Current plan is to change the _boot.py modification to check for the existence of a refresh_examples.py file or similar. If it does not exists, it will be generated with a single comment that says something like Delete this file to refresh the examples, then the frozen immutable example directory will be mounted, copied, then unmounted. This would ensure the examples only get copied one time, and give the user a way to refresh the examples if they want without having the confusion of having the frozen immutable directory always mounted.

@malcolm-sparkfun
Copy link
Contributor Author

@sfe-SparkFro Addressed with commit 5de809f

@sfe-SparkFro sfe-SparkFro mentioned this pull request Jul 24, 2025
Copy link
Collaborator

@sfe-SparkFro sfe-SparkFro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more minor things, looking good!

@sfe-SparkFro
Copy link
Collaborator

All seems well on my end, so I'm gonna merge. @malcolm-sparkfun let me know if you spot any issues with my commits, can easily fix if needed with another PR.

@sfe-SparkFro sfe-SparkFro merged commit d327ecd into features_for_launch Jul 30, 2025
1 check passed
@sfe-SparkFro sfe-SparkFro deleted the feature/build_release branch July 30, 2025 22:52
@malcolm-sparkfun
Copy link
Contributor Author

@sfe-SparkFro Those commits all look good to me, if you're happy with the .uf2 that your test release spit out then I'm happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants