-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/build release #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in person, but documenting here:
Change the frozen examples to only be added to the file system on first boot, not every boot.
Update - Current plan is to change the _boot.py
modification to check for the existence of a refresh_examples.py
file or similar. If it does not exists, it will be generated with a single comment that says something like Delete this file to refresh the examples
, then the frozen immutable example directory will be mounted, copied, then unmounted. This would ensure the examples only get copied one time, and give the user a way to refresh the examples if they want without having the confusion of having the frozen immutable directory always mounted.
…ng examples only happens once
@sfe-SparkFro Addressed with commit 5de809f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more minor things, looking good!
18c4039 changed the examples folder name
All seems well on my end, so I'm gonna merge. @malcolm-sparkfun let me know if you spot any issues with my commits, can easily fix if needed with another PR. |
@sfe-SparkFro Those commits all look good to me, if you're happy with the .uf2 that your test release spit out then I'm happy :) |
Added necessary build steps to generate a release artifact "firmware.uf2" on release. This image contains the firmware and the software in the "examples" directory.