Long Duration Survey-In Greater Than 65535-seconds #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for survey-in observation times greater that 65535 (16-bit) seconds. By changing to uint32_t will allow library to have observation time of 86400 seconds (24-hour) survey-in time.
Allow for uint32_t survey-in observation time to support >65535-seconds. This will allow for 24-hour (86400-second) survey-in times.
|
Hi @russ396 , |
|
Hi @russ396 , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes allow for the library to perform a survey-in longer that 65535-seconds. Currently the observation time is uint16_t allowing for 65535-seconds. I wish to perform survey at 86400-seconds (24-hours). This requires a uint32_t to store the value.