Skip to content

Fix compilation for AVR DA- and DB-series MCUs #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2022
Merged

Fix compilation for AVR DA- and DB-series MCUs #114

merged 5 commits into from
Feb 28, 2022

Conversation

nabelekt
Copy link
Contributor

No description provided.

@nabelekt nabelekt changed the base branch from main to release_candidate February 25, 2022 21:04
@PaulZC
Copy link
Collaborator

PaulZC commented Feb 25, 2022

Hi Thomas (@nabelekt ),
Thank you for submitting this PR. Just for information, can you tell me which board package you are using? Is it DxCore?
Best wishes,
Paul

@nabelekt
Copy link
Contributor Author

Yes, I am using DxCore.

Thanks.
Thomas

@PaulZC
Copy link
Collaborator

PaulZC commented Feb 28, 2022

Hi Thomas (@nabelekt ),
Thanks again for this. Merging for testing... I think I may change this to ARDUINO_ARCH_MEGAAVR to cover both families in one go, but I will let you know.
Best wishes,
Paul

@PaulZC PaulZC merged commit 238617a into sparkfun:release_candidate Feb 28, 2022
PaulZC added a commit that referenced this pull request Feb 28, 2022
@PaulZC
Change #114 to ARDUINO_ARCH_MEGAAVR
9243493
@PaulZC
Copy link
Collaborator

PaulZC commented Feb 28, 2022

Hi Thomas,
I am going with ARDUINO_ARCH_MEGAAVR. Please see this commit for the changes. It covers both DA and DB in one go. I have tested it using IDE 1.8.13 on Windows - please check it on your platform. Thanks!
Best wishes,
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabelekt @PaulZC