Skip to content

Incorrect configuration file name in Facet #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amlago opened this issue Sep 18, 2023 · 2 comments
Closed

Incorrect configuration file name in Facet #658

amlago opened this issue Sep 18, 2023 · 2 comments
Labels
In Release Candidate

Comments

@amlago
Copy link

amlago commented Sep 18, 2023

facet v3.8
Incorrect configuration file name in Facet

With version 3.8 the facet configuration file is called SFE-Surveyor-settings-0.txt instead of SFE-Facet-settings-0.txt

I realized that when I updated I didn't have any of my data saved.
When reviewing, I confirmed the file name change or the misidentification of the equipment.
nseidle added a commit that referenced this issue Sep 19, 2023
@nseidle
Load partial settings after platform is dected
f43e28b 
So that setSettingsFileName has correct info. Reversion of [this commit](718f07c#diff-b1c05b3c11dc036b5248d5537c2f451b6040a30a1ee28bfe8a970b2bc7af0007R119). We no longer need power button filtering setting so this is ok. Fix for issue #658.
@nseidle
Copy link
Member

nseidle commented Sep 19, 2023

Thanks for reporting! Fixed.

@nseidle
Copy link
Member

nseidle commented Sep 19, 2023

This is fixed in v3.8. Please let us know if you see any other problems.

@nseidle nseidle closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Release Candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nseidle @amlago