Skip to content

Unit does rolling reset during factory reset with settings file #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nseidle opened this issue Jun 28, 2023 · 1 comment
Closed

Unit does rolling reset during factory reset with settings file #519

nseidle opened this issue Jun 28, 2023 · 1 comment
Labels
In Release Candidate

Comments

@nseidle
Copy link
Member

nseidle commented Jun 28, 2023

While doing a factory reset, using the settings file (sizeOfSettings= 1 method) device will Factory Reset, reset, then show Factor Reset again.

This is caused because the sdSemaphore is already taken while the settings file is being loaded (and sizeOfSettings is read from the file) when the factoryReset() is issued. The solution is to make factoryReset aware of the state of the sdSemaphore.
nseidle added a commit that referenced this issue Jun 28, 2023
@nseidle
Pass state of sdSemaphore into factoryReset()
e906fbc 
Fix for issue #519
@nseidle nseidle mentioned this issue Jul 27, 2023
Merged
@nseidle
Copy link
Member Author

nseidle commented Jul 27, 2023

This has been added to the latest v3.6 release.

@nseidle nseidle closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Release Candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nseidle