[Release Candidate] PointPerfect RTCM corrections still active - after being enabled then disabled via the serial menu

[PaulZC]

To replicate:

Upload release_candidate (July 10th) onto Postcard
No SD card inserted
Do a Factory Reset
Provide WiFi credentials via the serial menu
Exit the menus
Activate PointPerfect Flex NTRIP/RTCM via the menus
Exit the menus
WiFi connects to ThingStream
Corrections are received
Postcard goes int RTK Fix almost instantaneously

Disable PointPerfect via the menus
Exit the menus

WiFi and NTRIP corrections are still active

Force a system reset via the menus (s d r)
Firmware restarts, starts WiFi, resumes NTRIP corrections

Corrections remain enabled. I haven't yet found a way to stop them - other than uploading firmware or doing a factory reset

TODO: check if this happens with an SD card inserted

[PaulZC]

Ah. It's because settings.enableNtripClient is getting set to true (correctly, because Flex NTRIP is an NTRIP Client with Caster Host/Port/User etc.) but isn't getting set to false when PointPerfect is subsequently disabled.

[nseidle]

This was by design, but I agree it's jarring. Because we're basically 'filling in' the NTRIP credentials for the user, I wasn't comfortable turning off NTRIP, in the case the user had entered new/different credentials. If there's a better series of events, please make it happen.

[PaulZC]

Do we know if the PP NEAR-RTCM User Name and Password need to be kept confidential? Is knowledge of the user name and password possibly open to abuse?

Probably / hopefully not? I'm sure ThingStream will have a rule that only one device can use those credentials and any one time. And I'm sure they would be deactivated as soon as the plan subscription expires.

My plan will be to record settings.pointPerfectService when entering the PP Menu. On exiting the PP menu, if settings.pointPerfectService has gone from a needing-NTRIP state to a not-needing-NTRIP state, I'll set settings.enableNtripClient to false just as a precaution. But won't delete the Host/UserName/Password just in case the user wants to turn it back on manually.

That logic is a little wooly. Our future selves can rework it if need be...

[nseidle]

Do we know if the PP NEAR-RTCM User Name and Password need to be kept confidential? Is knowledge of the user name and password possibly open to abuse?

IMO no. Unlike the key based PointPerfect services, each NTRIP account has unique credentials. They don't change (roll over like the keys) but I'm not concerned if a user sees their credentials. Additionally, PointPerfect blocks (I'm pretty sure) simultaneous use of a given credential set.

My plan will be...

If PointPerfect Flex NTRIP/RTCM is enabled, and then the user wants to switch to PointOne Nav, they modify the NTRIP Client. If they then turn off PointPerfect, what do we do? Turn off the NTRIP Client disabling PointOne Nav?

As the complexity of the logic increased, I decided to treat the PointPerfect ZTP for RTCM as an NTRIP 'filler'. If previous NTRIP Client credentials are there, they get nuked. If the user modifies the NTRIP credentials, that's on them.

Again, if you have a better idea, let me know. I just don't want to add too much code logic to make sure a very rare use case doesn't shoot themselves in the foot. There's not enough bubble wrap in the world to protect all users in all situations.

[PaulZC]

Agreed. But if I enable PP NTRIP through the PP Menu. Then use the same menu to disable PP NTRIP, I expect it to be disabled. Not left enabled as it is currently. I'm unlikely to remember that I also have to disable NTRIP from a completely separate menu... I think #683 does just enough? Let me know... Cheers!

[nseidle]

Works for me!