Fix elapsed and timestamp calculation on Linux #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Aug 31, 2018
| elapsed: date - (stat.start * 1000), | ||
| timestamp: stat.start * 1000, // start date | ||
| elapsed: (stat.uptime * 1000) - (stat.start * 1000), // process uptime minus start time | ||
| timestamp: date, |
There was a problem hiding this comment.
I think that this should be the uptime of the process in ms since epoch but I'm not sure. @simonepri could you confirm? Thanks!
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 9 9
Lines 335 335
=======================================
Hits 304 304
Misses 31 31
Continue to review full report at Codecov.
|
|
Thanks @filipesilva ! I'm going to fix the timestamp. |
|
Nevermind, this looks consistent between OSes! Thanks for fixing this! |
|
Thanks for merging this! |
|
published in 2.0.17! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #80