Skip to content

Scj/update/smtp validate #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2023
Merged

Scj/update/smtp validate #973

merged 6 commits into from
Apr 24, 2023

Conversation

@scjohns
Copy link
Contributor

@scjohns scjohns commented Apr 21, 2023

Test plan

  • Validate that adding smtp configs to a validation.yaml file will attempt to send a test
  • Validate that not including smtp in validation.yaml does not trigger an attempt to send a test

@scjohns scjohns requested a review from jdpleiness April 21, 2023 14:52
jasonhawkharris
jasonhawkharris approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jasonhawkharris jasonhawkharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scjohns scjohns merged commit 1ef7956 into main Apr 24, 2023
@scjohns scjohns deleted the scj/update/smtp-validate branch April 24, 2023 14:56
scjohns added a commit that referenced this pull request Apr 24, 2023
@scjohns
Scj/update/smtp validate (#973)
99d5ab5 
* add config for smtp

* add function for smtp

* smtp enabled check

* lint

* change Smtp.Test to Smtp.Enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonhawkharris jasonhawkharris jasonhawkharris approved these changes

@jdpleiness jdpleiness Awaiting requested review from jdpleiness

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scjohns @jasonhawkharris