This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix: launch script would fail if yarn was not run before #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
nicksnyder
reviewed
Jan 22, 2019
pkg/version/minversion/minversion.go
Outdated
| @@ -0,0 +1,18 @@ | |||
| // Ensure that users are running Go 1.11 or newer | |||
|
|
|||
| // Package minversion prints a boolean stating whether users are running the minimum required Go version. | |||
There was a problem hiding this comment.
Suggested change
| // Package minversion prints a boolean stating whether users are running the minimum required Go version. | |
| // Command minversion prints a boolean stating whether users are running the minimum required Go version. |
dev/launch.sh
Outdated
|
|
||
| if [ "$goversion" == "$min" ] && [ "$goversion" != "$minimumgo" ] ; then | ||
| echo "Go version $minimumgo is required; found $goversion" | ||
| goversion_above_111=$(go run ./pkg/version/minversion) |
There was a problem hiding this comment.
I don't think this variable should reference the actual version being enforced (as that is contained within the minversion binary).
pkg/version/minversion/minversion.go
Outdated
| func main() { | ||
| rawVersion := runtime.Version() | ||
| versionNumber := strings.TrimPrefix(rawVersion, "go") | ||
| fmt.Println(version.Compare("1.11.0", versionNumber, "<=")) |
There was a problem hiding this comment.
It might be easier and more natural to rely on exit codes instead
os.Exit(1) // minimum version not met means non-zero exit code
pkg/version/minversion/minversion.go
Outdated
| @@ -0,0 +1,18 @@ | |||
| // Ensure that users are running Go 1.11 or newer | |||
There was a problem hiding this comment.
I would remove this comment and just leave the package comment.
|
@nicksnyder based on your comments I just moved everything (including exit + error message) into the minversion command, and run it in the launch script. |
nicksnyder
approved these changes
Jan 23, 2019
pkg/version/minversion/minversion.go
Outdated
| @@ -0,0 +1,22 @@ | |||
| // Command minversion prints a boolean stating whether users are running the minimum required Go version. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/sourcegraph/sourcegraph/issues/1914 using the solution described in https://github.com/sourcegraph/sourcegraph/issues/1914#issuecomment-454685052.