This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[WIP] cmd/atomic-migrations-test: Atomic migrations test command #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsenart
requested review from
keegancsmith,
nicksnyder,
emidoots and
KattMingMing
This commit introduces an isolated atomic migrations test command to reliably reproduce these issues: - golang-migrate/migrate#55 - https://github.com/sourcegraph/sourcegraph/issues/1491
tsenart
force-pushed
the
tsenart/atomic-migrations
branch
from
a176f03 to
bd2321a
Compare
tsenart
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set introduces:
db/dbconn.gothat safely ignores the error we're seeing and thus fixes There may be a problem with how we do DB migrations concurrently? #1491. See the code comment for more details.Since I shared this PR in golang-migrate/migrate#55 with the test case, I'd like to keep the
atomic-migrations-testcode around. If there's a better place for it, please advice.