Skip to content

Fix bug where an interface definition had a conflicting symbol with a const in the same file #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Fix bug where an interface definition had a conflicting symbol with a const in the same file #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f24a8d6
Reproduce issue with conflicting const/interface
olafurpg Nov 11, 2022
cab89eb
Fix the bug
olafurpg Nov 11, 2022
386af62
Document why we have commented out code
olafurpg Nov 11, 2022
083c505
Add comment explaining why we avoid ambiguous results at definitions
olafurpg Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions snapshots/input/syntax/src/conflicting-const-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export const ConflictingConst = 42
export interface ConflictingConst {}
9 changes: 9 additions & 0 deletions snapshots/output/syntax/src/conflicting-const-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export const ConflictingConst = 42
// definition syntax 1.0.0 src/`conflicting-const-interface.ts`/
//documentation ```ts\nmodule "conflicting-const-interface.ts"\n```
// ^^^^^^^^^^^^^^^^ definition syntax 1.0.0 src/`conflicting-const-interface.ts`/ConflictingConst.
// documentation ```ts\ninterface ConflictingConst\n```
export interface ConflictingConst {}
// ^^^^^^^^^^^^^^^^ definition syntax 1.0.0 src/`conflicting-const-interface.ts`/ConflictingConst.
Copy link
Contributor Author

@olafurpg olafurpg Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected behavior

Suggested change
// ^^^^^^^^^^^^^^^^ definition syntax 1.0.0 src/`conflicting-const-interface.ts`/ConflictingConst.
// ^^^^^^^^^^^^^^^^ definition syntax 1.0.0 src/`conflicting-const-interface.ts`/ConflictingConst#

// documentation ```ts\ninterface ConflictingConst\n```