Print message when npm/yarn install fails during auto-indexing #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, auto-indexing jobs silently ignored npm/yarn install failures making it difficult to understand why the failures were ignored.
olafurpg
force-pushed
the
non-silent-failure
branch
from
d4ee9e0 to
b788699
Compare
varungandhi-src
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, auto-indexing jobs silently ignored npm/yarn install
failures making it difficult to understand why the failures were
ignored.
Test plan
I ran
false || echo "hello"to verify that the exit code remains non-zero.