bump kotlin + compiler api dependency to 1.8.21 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
May 5, 2023
Contributor
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
Do we leave versions pre 1.8.21 behind to move to non-deprecated stuff?
Given the limited usage this plugin gets, I think it's fine to move forward and recommend using an older version of this plugin for users who are not able to upgrade to the latest Kotlin.
keynmol
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buncha deprecation warnings, do we leave versions pre 1.8.21 behind to move to non-deprecated stuff? (see e.g.: https://sourcegraph.com/github.com/JetBrains/kotlin/-/commit/8b42638afa00626078aa7d04ea62a129f0323cdc)
Test plan
Unit tests 😊