This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Evict cache entries when the connection closes #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismwendt
force-pushed
the
clean-up-cache
branch
from
f6d0e1f to
8926dcb
Compare
keegancsmith
approved these changes
Feb 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cache entries were never being evicted.
Now, go-langserver calls evicts cache entries oldest-first until the
MaxCacheSizeBytesis satisfied when a connection is closed (e.g. WebSocket disconnect).BuildServerkeeps track of archives it has opened (only the current repository for now), and implementio.CloserbyClose()ing archives that it had opened, which in turn callsEvict().Fixes sourcegraph/sourcegraph-go#20