Skip to content

Conversation

@arsalan0c
Copy link
Member

@arsalan0c arsalan0c commented May 2, 2020

This PR adds support for specifying the variant and execution method for a test in its first line like so:

// variant=non-det executionMethod=interpreter

It also replaces all usages of AWK in the script with grep and cut.

Depends on source-academy/js-slang#549

@arsalan0c arsalan0c requested a review from martin-henz May 2, 2020 07:21
@arsalan0c arsalan0c changed the title Add execution method support for test script (and replace AWK) Add execution method and variant support for test script (and replace AWK) May 2, 2020
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution!

@martin-henz martin-henz merged commit 39147ef into source-academy:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants