Refactor pair implementation to be array-free #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-henz
requested changes
Mar 18, 2020
src/virtual-machines/source-2.js
Outdated
| } | ||
|
|
||
| function show_array_value(address) { | ||
| function is_denotable_value(addr) { |
Member
There was a problem hiding this comment.
"denotable" means names can refer to the value. The name then "denotes" the value. I don't think that's the way you use the word is correct. For example null should be a denotable value.
moziliar
force-pushed
the
mo/upgrade-SECD-to-Source-2
branch
from
89f44e1 to
131f2ae
Compare
martin-henz
pushed a commit
that referenced
this pull request
Apr 17, 2020
Ding/impl mark region in source 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.