Add block scoping for conditional statements and expressions #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 75
💛 - Coveralls |
remo5000
approved these changes
Aug 28, 2018
Contributor
remo5000
left a comment
remo5000
left a comment
There was a problem hiding this comment.
LTGM, thanks for taking the time to do this! 😄
martin-henz
added a commit
that referenced
this pull request
May 2, 2020
…ixes) (#594) * Fix bug: yield new array (#40) * fix bug: yield new array for array expression * Add user friendly REPL message (#43) * add user friendly REPL message * Add randomized amb operator (#15) Adds the ambR operator which functions similarly to amb but makes choices randomly instead of sequentially. Also adds landing page and library documentation for the operator, and adds this operator into the specs. * Add while loops (#39) This PR adds support for while loops, including break, continue and return statements in the loop body. It also tweaks the scheduler so that stackoverflow errors are captured and displayed to the user. Co-authored-by: anubh-v <[email protected]> * Clear the stack trace of any error created in REPL (#46) * Add for loops (#41) This PR adds support for for loops, including break, continue and return statements in the loop body. Co-authored-by: Anubhav <[email protected]> * Add documentation for loops (#44) Co-authored-by: anubh-v <[email protected]> * Improve comments in non-det interpreter (#47) * Remove unhelpful comment * Fix spelling in comment Co-authored-by: Arsalan Cheema <[email protected]> Co-authored-by: martin-henz <[email protected]>
martin-henz
added a commit
that referenced
this pull request
May 4, 2020
* REPL: add variant option * . * Fix bug: yield new array (#40) * fix bug: yield new array for array expression * Add user friendly REPL message (#43) * add user friendly REPL message * Add randomized amb operator (#15) Adds the ambR operator which functions similarly to amb but makes choices randomly instead of sequentially. Also adds landing page and library documentation for the operator, and adds this operator into the specs. * Add while loops (#39) This PR adds support for while loops, including break, continue and return statements in the loop body. It also tweaks the scheduler so that stackoverflow errors are captured and displayed to the user. Co-authored-by: anubh-v <[email protected]> * Clear the stack trace of any error created in REPL (#46) * Add for loops (#41) This PR adds support for for loops, including break, continue and return statements in the loop body. Co-authored-by: Anubhav <[email protected]> * Add documentation for loops (#44) Co-authored-by: anubh-v <[email protected]> * Improve comments in non-det interpreter (#47) * Remove unhelpful comment * Fix spelling in comment * allow only supported chapter and variant combinations * format Co-authored-by: martin-henz <[email protected]> Co-authored-by: anubh-v <[email protected]> Co-authored-by: Anubhav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constdeclarations are now block-scoped to if statementsadding block scoping to for loops will come later
http://13.250.115.8/playground#chap=2&ext=NONE&prgrm=MYewdgzgLgBAHjAvDKAnArgUwNwChcCWAZgBRpYCUMA3rjPTKJLAskQIYA2EOuAvjEzdMNOgybR4SGB2F4%2B%2BONiA