Fix null and RegExp literal values being allowed #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 55
💛 - Coveralls |
ning-y
requested changes
Aug 16, 2018
src/rules/noUnspecifiedLiteral.ts
Outdated
| : this.node.value instanceof RegExp ? 'RegExp' | ||
| : '' | ||
| return ( | ||
| `A literal '${literal}' value is not allowed. Only string, boolean, and number literal values are allowed.` |
Member
There was a problem hiding this comment.
Prefer '${literal} literals are not allowed', to be consistent with the other disallowed stuff, .e.g
Line 1: Array expressions are not allowed
Contributor
Author
There was a problem hiding this comment.
@ningyuansg Agreed. Updated!
Member
|
Thanks, please publish and we can update cadet-frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Issues fixed