Skip to content

Conversation

openorclose
Copy link
Contributor

Compatibility issues with 3.1.18

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.093%

Totals Coverage Status
Change from base Build 1132: 0.0%
Covered Lines: 922
Relevant Lines: 2994

💛 - Coveralls

@podocarp
Copy link
Member

^3.1.17 works for me though I know 3.1.18 breaks it. Could it just be that the 3.1.18 version is being kept from previous installations despite specifying 3.1.17?

@openorclose
Copy link
Contributor Author

It could be a npm/yarn version difference too, when deciding what version of enzyme to use. I'll try cloning again and see what ^3.1.17 gets

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turns out to be necessary to get the frontend running.

@martin-henz martin-henz merged commit c93a895 into master Feb 24, 2019
@thomastanck thomastanck deleted the exact-enzyme-version branch February 24, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants