Skip to content

Conversation

loyaltypollution
Copy link
Contributor

@loyaltypollution loyaltypollution commented Sep 21, 2025

Description

The error #3377 is caused by the conductor flag being turned on automatically. The default evaluator is set to pie-slang, so the error message seen is an internal error created by pie-evaluator.js

We refactor the feature flag toggle code to

  1. avoid toggling conductor flag on automatically
  2. reset feature flags when languageDirectory flag is turned off

Fixes #3377

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17897223250

Details

  • 14 of 56 (25.0%) changed or added relevant lines in 7 files are covered.
  • 54 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 42.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/languageDirectory/LanguageDirectoryReducer.ts 1 5 20.0%
src/commons/sagas/LanguageDirectorySaga.ts 5 43 11.63%
Files with Coverage Reduction New Missed Lines %
src/commons/featureFlags/index.ts 4 78.57%
src/features/languageDirectory/LanguageDirectoryReducer.ts 8 50.0%
src/features/languageDirectory/LanguageDirectoryTypes.ts 11 38.89%
src/commons/sagas/LanguageDirectorySaga.ts 31 22.47%
Totals Coverage Status
Change from base Build 17819137218: -0.2%
Covered Lines: 21001
Relevant Lines: 51992

💛 - Coveralls

@tsammeow
Copy link
Contributor

should be fixed by #3355

@tsammeow tsammeow closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting "Error: The context {} is empty, but we are looking for display" for any program

3 participants