Skip to content

Conversation

@DesSnowy
Copy link
Contributor

Description
This pull request supports the usage of a new tab which shows the popular votes leaderboard in the contest voting assessments. Relevant frontend pull request has been opened.

Changes To Be Made

  • Added new popular_score field to answers
  • Added new methods which mirrors calculation for relative_score to popular_score
  • Added new popularVoteLeaderboard output for voting questions
  • Changed testcases to include popularVoteLeaderboard

@jayjay19630
Copy link
Contributor

Corresponding frontend PR: source-academy/frontend#2785

@coveralls
Copy link

coveralls commented Feb 18, 2024

Coverage Status

coverage: 94.992% (+0.05%) from 94.943%
when pulling b6b94f6 on DesSnowy:PopularVoteContest
into 3135f48 on source-academy:master.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delayed review. Thanks for working on this, I just have one comment below:

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 11154a6 into source-academy:master Feb 24, 2024
@DesSnowy DesSnowy deleted the PopularVoteContest branch February 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants