Add bookmark options to load username/password from env vars #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Is https://github.com/AGWA/git-crypt not an option? You can securely store the encrypted data right in your repo |
Contributor
Author
|
Thanks for the quick reply. git-crypt isn't suitable for us I'm afraid; we'd like to use existing Kubernetes secrets to specify username/password. I opened this PR in case this might be of value to you or other users of pgweb, but I also understand this is a very specific situation 😅 |
sosedoff
reviewed
Jan 20, 2023
Owner
|
Thank you! |
Contributor
Author
|
Likewise, and thanks for the great tool! |
Owner
|
Would you mind dropping me an email with some info on how you run pgweb in your org? This helps me plan for new features/improve things etc. |
jonaz
pushed a commit
to jonaz/pgweb
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep our configuration for pgweb in a private Git repository. Currently we still have to input the username and password every time, but it would be nice to refer to an environment variable in the bookmarks. That'll allow us to have the 'click-and-go' functionality without the security implications of keeping passwords stored in the repository itself. Using SSH keys is unfortunately not an option.