Allow rspec-rails 6 #217
Merged
Allow rspec-rails 6 #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
the
needs changelog label
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
tvdeyen
added
bug
tvdeyen
reviewed
Jan 18, 2024
rspec-rails < 6.0.2 is incompatible with Rails 7.1 because of stricter view path typecasting in Rails 7.1. This bug is fixed in rspec-rails 6.0.2. Without this, controller specs in extensions will break. rspec/rspec-rails#2631 This also raises the minimum version to rspec-rails 5 as Solidus 3.x needs Rails > 5.2, and rspec-rails 5 is the version for that Rails version.
mamhoff
force-pushed
the
allow-rspec-rails-6
branch
from
394651d to
ba2b820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rspec-rails < 6.0.2 is incompatible with Rails 7.1 because of stricter view path typecasting in Rails 7.1. This bug is fixed in rspec-rails 6.0.2. Without this, controller specs in extensions will break.
rspec/rspec-rails#2631
Checklist
The following are mandatory for all PRs: