refactor: 쿠키 정책 변경 - 환경에 따른 Domain과 SameSite=Lax

[nayonsoso]

관련 이슈

• resolves: refactor: stage환경에서도 도메인 고정하도록 #459

작업 내용

프론트 만옥님의 요청으로 local, dev 환경에서 Domain=.stage.solid-connection.com; SameSite=Lax; 가 설정되게 합니다.

[coderabbitai]

Walkthrough

1. RefreshTokenCookieManager 변경.
   • RefreshTokenCookieManager에서 SameSite 값을 properties.sameSite()에서 SameSite.LAX.attributeValue()로 고정했습니다.
   • 관련 import(org.springframework.boot.web.server.Cookie.SameSite)를 추가했습니다.
2. RefreshTokenCookieProperties 변경.
   • sameSite() 파생 로직과 isDomainSet() 보조 메서드를 삭제하고 cookieDomain만 노출하도록 변경했습니다.
   • SameSite 관련 import를 제거했습니다.
3. 테스트 수정 및 삭제.
   • RefreshTokenCookieManagerTest에서 sameSite mocking을 제거하고 기대값을 SameSite.LAX.attributeValue()로 갱신했습니다.
   • RefreshTokenCookiePropertiesTest 파일을 삭제했습니다.
4. 리소스 서브모듈 업데이트.
   • src/main/resources/secret의 서브모듈 포인터가 메타데이터-only 커밋으로 업데이트되었습니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• wibaek
• lsy1307
• whqtker
• Gyuhyeok99

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 42ca6bb and 647c437.

📒 Files selected for processing (1)

• src/main/resources/secret (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/main/resources/secret

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

src/main/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManager.java (2)

50-50: [2] SameSite=Lax 고정은 목적에 부합합니다. 다만 문자열 직접 지정으로 결합도를 낮춰보세요.

• 1. PR 목표인 SameSite=Lax 고정과 정확히 일치합니다.
  • 2. enum의 attributeValue() 대신 문자열 "Lax"를 바로 쓰면 Boot 내부 API 변화에 덜 민감해집니다.
  • 3. 테스트와도 쉽게 맞출 수 있습니다.

아래처럼 간단히 치환 가능합니다.

-                .sameSite(SameSite.LAX.attributeValue())
+                .sameSite("Lax")

---

13-13: 🚀 SameSite enum 의존성 경량화 제안
확인 결과, Spring Boot 3.x에서도 org.springframework.boot.web.server.Cookie.SameSite enum은 여전히 유효합니다! 그럼에도 문자열 직접 지정으로 결합도를 낮춰 유지보수를 더 편하게 만들어 봅시다.

변경사항 안내:
1️⃣ import 제거
- import org.springframework.boot.web.server.Cookie.SameSite; 삭제
2️⃣ 문자열로 교체
- ResponseCookie.from(...).sameSite("Lax") 사용
3️⃣ 유지보수 안정성 강화
- 향후 메이저 업그레이드 시 패키지/타입 이동 리스크 감소

가볍게 검토 후 반영하시면 좋겠습니다! 😄

src/test/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManagerTest.java (2)

22-22: [1] 테스트에서도 Boot enum 의존을 제거하면 업그레이드 내성이 좋아집니다.

• 1. 프로덕션 코드에서 문자열 "Lax"로 전환 시, 테스트도 같은 방식으로 검증하면 일관성이 좋아집니다.
  • 2. 외부(enum) 의존을 끊어두면 프레임워크 변경에 따른 불필요한 테스트 수정이 줄어듭니다.

-import org.springframework.boot.web.server.Cookie.SameSite;

---

64-64: [2] 검증 문자열을 고정해 enum 의존을 없애면 더 단단해집니다.

• 1. 헤더 포맷은 "SameSite=Lax"가 표준적인 표기입니다.
  • 2. enum.attributeValue() 대신 문자열을 직접 비교하면 테스트가 더 단순하고 안정적입니다.

-                () -> assertThat(header).contains("SameSite=" + SameSite.LAX.attributeValue())
+                () -> assertThat(header).contains("SameSite=Lax")

Also applies to: 86-86

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between afe27ab and 42ca6bb.

📒 Files selected for processing (4)

• src/main/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManager.java (2 hunks)
• src/main/java/com/example/solidconnection/auth/controller/config/RefreshTokenCookieProperties.java (0 hunks)
• src/test/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManagerTest.java (3 hunks)
• src/test/java/com/example/solidconnection/auth/controller/config/RefreshTokenCookiePropertiesTest.java (0 hunks)

💤 Files with no reviewable changes (2)

• src/main/java/com/example/solidconnection/auth/controller/config/RefreshTokenCookieProperties.java
• src/test/java/com/example/solidconnection/auth/controller/config/RefreshTokenCookiePropertiesTest.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build