-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: refreshToken 쿠키에서 환경별로 Domain 설정하도록 #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nayonsoso
merged 5 commits into
solid-connection:develop
from
nayonsoso:refactor/449-set-cookie-domain
Aug 15, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...java/com/example/solidconnection/auth/controller/config/RefreshTokenCookieProperties.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package com.example.solidconnection.auth.controller.config; | ||
|
|
||
| import org.springframework.boot.context.properties.ConfigurationProperties; | ||
| import org.springframework.boot.web.server.Cookie.SameSite; | ||
|
|
||
| @ConfigurationProperties(prefix = "token.refresh") | ||
| public record RefreshTokenCookieProperties( | ||
| String cookieDomain | ||
| ) { | ||
|
|
||
| public String sameSite() { | ||
| if (isDomainSet()) { | ||
| return SameSite.STRICT.attributeValue(); // 도메인을 지정한 경우 SameSite=Strict | ||
| } | ||
| return SameSite.NONE.attributeValue(); // 도메인을 지정하지 않은 경우 SameSite=None | ||
| } | ||
|
|
||
| private boolean isDomainSet() { | ||
| return cookieDomain != null && !cookieDomain.isBlank(); | ||
| } | ||
| } |
Submodule secret
updated
from e592f6 to 0e9f5d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
.../com/example/solidconnection/auth/controller/config/RefreshTokenCookiePropertiesTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package com.example.solidconnection.auth.controller.config; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import org.junit.jupiter.api.DisplayName; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.boot.web.server.Cookie.SameSite; | ||
|
|
||
| @DisplayName("리프레시 토큰 쿠키 설정 테스트") | ||
| class RefreshTokenCookiePropertiesTest { | ||
|
|
||
| @Test | ||
| void Domain을_지정했으면_SameSite가_Strict() { | ||
| // given | ||
| RefreshTokenCookieProperties properties = new RefreshTokenCookieProperties("example.com"); | ||
|
|
||
| // when | ||
| String sameSite = properties.sameSite(); | ||
|
|
||
| // then | ||
| assertThat(sameSite).isEqualTo(SameSite.STRICT.attributeValue()); | ||
| } | ||
|
|
||
| @Test | ||
| void Domain을_지정하지_않았으면_SameSite가_None() { | ||
| // given | ||
| RefreshTokenCookieProperties properties = new RefreshTokenCookieProperties(null); | ||
|
|
||
| // when | ||
| String sameSite = properties.sameSite(); | ||
|
|
||
| // then | ||
| assertThat(sameSite).isEqualTo(SameSite.NONE.attributeValue()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.