-
Notifications
You must be signed in to change notification settings - Fork 8
style: 팀 공통 컨벤션 적용 #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: 팀 공통 컨벤션 적용 #385
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 168 files out of 275 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일 변경이 엄청나네요 ... 이제라도 컨벤션을 파일화하게 되어 참 다행이라고 생각합니다 !!
하나 머리에 스쳐지나간 내용이 있는데, 컨벤션 xml 파일을 CI 스크립트에서 사용할 수 있게끔 하면 어떨까요 ? 혹여나 reformatting을 하지 못하고 merge했을 때, 이를 잡아낼 수 있을 것 같습니다.
두 가지 의문이 들긴 하네요.
- (구현이 크게 복잡하지 않은 선에서) 실제로 가능한가(관련 레퍼런스는 있긴 합니다)
- 이렇게까지 해야 할까 ..?
| * | ||
| * 수정 내역: | ||
| * - INDENT_SIZE, TAB_SIZE 를 2에서 4로 변경 | ||
| * - right_margin을 100에서 500으로 증가 (현재는 코드 길이와 관련된 개행 컨벤션이 없는 상태) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다음 회의 때 right_margin 도 같이 결정해볼까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다! 😊
Gyuhyeok99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 기술 알려주셔서 감사합니다 ㅎㅎ 적용했습니다!
lsy1307
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 지금까지 컨벤션 관련해서 놓친 부분이 많았는데 이젠 더 잘 지킬 수 있을 것 같아용...! 감사합니다 : )
관련 이슈
작업 내용
➡️ 코드 컨벤션과 관련된 피드백을 줄입니다.
이렇게 설정이 들어가서 import 한 후,
main.java와main.test에 reformat 해서 확인해보세요~특이 사항
우리 프로젝트에서 기존의 indent도 4이므로 4로 바꿉니다!