Skip to content

Conversation

@nayonsoso
Copy link
Collaborator

@nayonsoso nayonsoso commented Jul 13, 2025

관련 이슈

작업 내용

  • 전체 코드 스타일을 통일합니다.
  • reformat code로 코드 스타일이 적용될 수 있도록, 코드 스타일 xml 파일을 공유합니다.

➡️ 코드 컨벤션과 관련된 피드백을 줄입니다.

image

이렇게 설정이 들어가서 import 한 후, main.javamain.test 에 reformat 해서 확인해보세요~

특이 사항

  • 구글의 컨벤션은 기본적으로 indent가 2로 되어있었는데, 요즘은 4를 쓴다고 하고
    우리 프로젝트에서 기존의 indent도 4이므로 4로 바꿉니다!
  • record 클래스에도 클래스 시작 개행이 자동 추가되었습니다.

@nayonsoso nayonsoso self-assigned this Jul 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 13, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

168 files out of 275 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@whqtker whqtker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일 변경이 엄청나네요 ... 이제라도 컨벤션을 파일화하게 되어 참 다행이라고 생각합니다 !!

하나 머리에 스쳐지나간 내용이 있는데, 컨벤션 xml 파일을 CI 스크립트에서 사용할 수 있게끔 하면 어떨까요 ? 혹여나 reformatting을 하지 못하고 merge했을 때, 이를 잡아낼 수 있을 것 같습니다.

두 가지 의문이 들긴 하네요.

  1. (구현이 크게 복잡하지 않은 선에서) 실제로 가능한가(관련 레퍼런스는 있긴 합니다)
  2. 이렇게까지 해야 할까 ..?

*
* 수정 내역:
* - INDENT_SIZE, TAB_SIZE 를 2에서 4로 변경
* - right_margin을 100에서 500으로 증가 (현재는 코드 길이와 관련된 개행 컨벤션이 없는 상태)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 회의 때 right_margin 도 같이 결정해볼까요 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다! 😊

Copy link
Contributor

@Gyuhyeok99 Gyuhyeok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 기술 알려주셔서 감사합니다 ㅎㅎ 적용했습니다!

Copy link
Contributor

@lsy1307 lsy1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 지금까지 컨벤션 관련해서 놓친 부분이 많았는데 이젠 더 잘 지킬 수 있을 것 같아용...! 감사합니다 : )

@nayonsoso nayonsoso merged commit 187e9e7 into solid-connection:develop Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

style: 프로젝트에 팀 공통 코드 스타일 적용

4 participants