feat: 지원 시 지원 횟수 응답값 추가 #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayonsoso
approved these changes
Feb 20, 2025
Comment on lines
5
to
11
| public record ApplicationSubmissionResponse( | ||
| boolean isSuccess) { | ||
| int applyCount | ||
| ) { | ||
| public static ApplicationSubmissionResponse from(Application application) { | ||
| return new ApplicationSubmissionResponse(application.getUpdateCount()); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
"업데이트 횟수" 반환하는 것 좋네요!
프론트에서 메세지를 주기도 편해보입니다.
다만 api 문서 최신화를 위해서 api docs도 업데이트해주세요~
Contributor
Author
There was a problem hiding this comment.
Response만 바뀌었는데 Response도 바꾸는 곳이 있나요?
src/main/java/com/example/solidconnection/application/service/ApplicationSubmissionService.java
Show resolved
Hide resolved
src/main/resources/db/migration/V10__change_update_count_default_value.sql
Outdated
Show resolved
Hide resolved
wibaek
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
특이 사항
기존 지원서 제출 api 서비스 로직에서 성공 시 true, 실패 시 예외로 되어있었는데 이렇게되면 true를 반환할 이유가 없다고 생각해서 바로 지원횟수를 응답하는 응답 dto로 반환하게 변경하였습니다.