fix: 프로필 수정 API에서 닉네임, 이미지 부분 업데이트 가능하도록 수정 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wibaek
approved these changes
Feb 17, 2025
Member
wibaek
left a comment
wibaek
left a comment
There was a problem hiding this comment.
validateProfileImageNotEmpty()는 지우는게 맞겠네요.
현재는 이미지가 null이면 변경없게 해두었는데, null 이면 삭제하고 키가 없으면 유지하는 것도 한 방법이 될수 있겠네요. 저는 현재 구현이 좋은 것 같습니다.
| if (imageFile != null && !imageFile.isEmpty()) { | ||
| if (!isDefaultProfileImage(siteUser.getProfileImageUrl())) { | ||
| s3Service.deleteExProfile(siteUser); | ||
| } |
Member
There was a problem hiding this comment.
삭제전에 업로드 시도하는게 어떨까요? S3은 트랜잭션이 없으니까요 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
PATCH 메서드에 따라 전송한 리소스만 변경되게 수정하였습니다.
리뷰 요구사항 (선택)
파일이 empty인 상태일 때 굳이 예외를 던지기보단 변경을 안하는 게 클라이언트 입장에서 더 좋은 거 같아서 validateProfileImageNotEmpty 메서드는 그냥 지웠는데 괜찮을까요?