-
Notifications
You must be signed in to change notification settings - Fork 8
지원서(application) 테이블에서 학점/어학 인증 분리 및 지원 절차 수정 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leesewon00
merged 16 commits into
solid-connection:main
from
leesewon00:refactor/57-apply-score-separation
Dec 4, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a28e917
feat: 학점, 어학 엔티티 정의
leesewon00 f451720
feat: 학점, 어학 레포지토리 정의
leesewon00 9382dc4
feat: 학점, 어학 서비스 로직 추가
leesewon00 1e10e9c
feat: 학점, 어학 컨트롤러 로직 추가
leesewon00 18c9cda
feat: 학점, 어학 관련 DTO 정의
leesewon00 d067ba4
feat: 학점, 어학 관련 예외 정의
leesewon00 23be4d7
feat: 학점, 어학 레포지토리 테스트 로직 추가
leesewon00 802475b
feat: 학점, 어학 서비스 테스트 로직 추가
leesewon00 feb7109
refactor: 수정안에 따른 지원 절차 수정
leesewon00 5f2f330
refactor: 수정안에 따른 지원 절차 테스트 로직 수정
leesewon00 e270e23
feat: api naming 통일을 위한 경로 수정
leesewon00 2faebcd
refactor: 조회 목적에 맞게 함수명 수정
leesewon00 1ccf4a5
refactor: 지원서 제출에서 기존이력을 soft delete 방식으로 처리
leesewon00 b9f470f
refactor: 예상하지 못한 쿼리 실행을 방지하기 위해 즉시로딩 지연로딩으로 수정
leesewon00 3f2e719
refactor: GpaScore, LanguageTestScore 이력 수정 대신 새로운 객체 생성하여 처리
leesewon00 96d6ab3
fix: 추천 대학 목록 조회 테스트 실패로 즉시로딩으로 수정
leesewon00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/com/example/solidconnection/application/dto/ApplyRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package com.example.solidconnection.application.dto; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import jakarta.validation.constraints.NotNull; | ||
|
|
||
| @Schema(description = "지원서 제출") | ||
| public record ApplyRequest( | ||
| @NotNull(message = "gpa score id를 입력해주세요.") | ||
| @Schema(description = "지원하는 유저의 gpa score id", example = "1") | ||
| Long gpaScoreId, | ||
|
|
||
| @NotNull(message = "language test score id를 입력해주세요.") | ||
| @Schema(description = "지원하는 유저의 language test score id", example = "1") | ||
| Long languageTestScoreId, | ||
|
|
||
| UniversityChoiceRequest universityChoiceRequest | ||
| ) { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용자가 직접 id 를 입력하도록 바뀌는 건가요?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말씀하신 대로 토익과 토플 성적이 모두 등록될 수 있기에 여기서 골라서 지원하는 방식입니다.
유저가 화면상의 본인 성적을 선택하게되면 해당 성적의 id를 api로 전송하는 방식입니다.
회원마다 성적을 여러개를 보유할 수 있어서 선택하여 지원하는 방식으로 진행했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
충분한 답변이 되었는지 잘 모르겠네요ㅜ
궁금한점 있으시면 말씀해주세요!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 이해했습니다😊