This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Upgrade to Solana 1.18.2 #6278
Merged
Upgrade to Solana 1.18.2 #6278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
upgrade-solana-1.18.2
branch
6 times, most recently
from
6a2ce11 to
2d8b4d3
Compare
samkim-crypto
force-pushed
the
upgrade-solana-1.18.2
branch
from
2d8b4d3 to
c5e7e42
Compare
This was referenced Feb 28, 2024
joncinque
reviewed
Feb 28, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just one little question on the change to the enums in token-lending, but the rest looks great!
Contributor
There was a problem hiding this comment.
Just so I'm sure I understand -- with 1.17, it was implicitly repr(u32), correct? If so, can we do that instead of repr(u8)? I'm worried of some strange issue when trying to deserialize the pyth types otherwise
Contributor
Author
There was a problem hiding this comment.
Oops yes, I think it was repr(u32) with 1.17. I'll make the update!
samkim-crypto
force-pushed
the
upgrade-solana-1.18.2
branch
from
b3f5a4a to
92f3a82
Compare
joncinque
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try_to_vecwas deprecated with version 1.x, so I replaced this function withborsh::to_vecthroughout the repoallow![(deprecated)]on these tools and defer resolving the deprecations to follow-up PRs.repr(C)in solana version 1.17 and 1.18 seem to have different representations in memory (https://discord.com/channels/428295358100013066/967028962746327060/1210701837007724564) causing errors in sometoken-lendingtests. I updated the enums in token-lending torepr(u32), which should have the same memory representation as inrepr(C)with solana 1.17.