Skip to content

Better error handling in Buffered#sysread. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better error handling in Buffered#sysread. #6

wants to merge 2 commits into from

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jun 19, 2025 •
edited
Loading

OpenSSL::SSL::SSLSocket#read_nonblock can raise Errno::EBADF if the IO is closed. However IO#read_nonblock raises IOError. For consistency's sake, try to improve the error handling.

Types of Changes

  • Maintenance.

Contribution

@ioquatix ioquatix mentioned this pull request Jun 19, 2025
Open
@ioquatix ioquatix force-pushed the sysread-closed-check branch from 81c7dbe to d8bbeb5 Compare June 19, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ioquatix