-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Garbage collection #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbage collection #408
Conversation
|
https://gist.github.com/1100205 Benchmark test, I didn't think something like would be suitable for our unit tests, so we might needs need have some sort of performance benchmark suite where these kind of tests can run. |
|
Not merging this one as I still want to make some changes to the handshake store logic to make garbage collection more flexible. |
|
Sure, but this is a major memory leak and can leak hunderds om kb in a production env. So i suggesting fixen it now instead of after another release as ALLOT of users are suffering from this bug. ~ Arnout Kazemier On Jul 31, 2011, at 3:51 AM, [email protected] wrote:
|
Conflicts: lib/manager.js
|
Hi, I'm getting this error TypeError: Cannot use 'in' operator to search for 'issued' in null Any ideas why this is happening? Thanks, |
|
I am also getting this error. I temporarily put a fix by forking and checking for null value of handshake. Any ideas on what would have caused this error? Thanks, |
|
@scanales / @vikramnet2003 - did you find a solution? |
|
In my system i have about 6 different system that have connected the same Redis Store for Socket.io. |
|
I am also getting this error when using socket.io-clusterhub. did anyone find out a solutions? |
Garbage collection function to kill unused handshakes.