Skip to content

Conversation

@3rd-Eden
Copy link
Contributor

Garbage collection function to kill unused handshakes.

@3rd-Eden
Copy link
Contributor Author

https://gist.github.com/1100205

Benchmark test, I didn't think something like would be suitable for our unit tests, so we might needs need have some sort of performance benchmark suite where these kind of tests can run.

@rauchg
Copy link
Contributor

rauchg commented Jul 31, 2011

Not merging this one as I still want to make some changes to the handshake store logic to make garbage collection more flexible.

@rauchg rauchg closed this Jul 31, 2011
@3rd-Eden
Copy link
Contributor Author

Sure, but this is a major memory leak and can leak hunderds om kb in a production env.

So i suggesting fixen it now instead of after another release as ALLOT of users are suffering from this bug.

~ Arnout Kazemier

On Jul 31, 2011, at 3:51 AM, [email protected] wrote:

Not merging this one as I still want to make some changes to the handshake store logic to make garbage collection more flexible.

Reply to this email directly or view it on GitHub:
#408 (comment)

@rauchg rauchg reopened this Aug 4, 2011
rauchg added a commit that referenced this pull request Aug 4, 2011
@rauchg rauchg merged commit d86ffcf into socketio:master Aug 4, 2011
@scanales
Copy link

scanales commented Jan 7, 2013

Hi, I'm getting this error

TypeError: Cannot use 'in' operator to search for 'issued' in null
at String.IN (native)
at Manager.garbageCollection (/node_modules/socket.io/lib/manager.js:1021:21)
at Timer. (native)
at Timer.ontimeout (timers.js:223:14)

Any ideas why this is happening?

Thanks,

@vikram-chaitanya
Copy link

I am also getting this error. I temporarily put a fix by forking and checking for null value of handshake. Any ideas on what would have caused this error?

Thanks,
Vikram

@gkorland
Copy link

gkorland commented Feb 6, 2014

@scanales / @vikramnet2003 - did you find a solution?

@adrian-ludwig
Copy link

In my system i have about 6 different system that have connected the same Redis Store for Socket.io.
This error happens only when we restart one of the systems that have connected clients.

@nguyenvansutt
Copy link

I am also getting this error when using socket.io-clusterhub. did anyone find out a solutions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants