Skip to content

Tweak to migration guide on http://socket.io website #1908

@mikermcneil

Description

@mikermcneil

Hey y'all- I was poking around for where to send a PR, but looks like the website has database-hosted content. Anyways minor thing, but I wanted to be sure and leave a note about it while it was fresh on my mind:

On http://socket.io/docs/migrating-from-0-9/, we're not currently mentioning anything about the io.sockets.clients() method being deprecated.

e.g.

/Users/mikermcneil/code/sails/lib/hooks/pubsub/index.js:296
        return sails.io.sockets.clients(roomName);
                                ^
TypeError: Object #<Namespace> has no method 'clients'
  at Object.sails.sockets.subscribers (/Users/mikermcneil/code/sails/lib/hooks/pubsub/index.js:296:33)

When I get a solution sorted out momentarily, I'll post it here for anyone else who might find this issue on the googles.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions