Update, from msgpack-lite to notepack.io (support new version of soc… #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eti.io-redis) Fix, removed old namespace tag Update dependencies
darrachequesne
requested changes
May 12, 2017
Member
darrachequesne
left a comment
darrachequesne
left a comment
There was a problem hiding this comment.
Nice, thanks for the pull request 👍
Before merging, could you please:
- remove nodejs 0.10 and 0.12 from travis configuration
- remove the hasBin check (and the has-binary dependency) (related: socketio/socket.io#2923)
index.js
Outdated
| if (opts.rooms && opts.rooms.length) { | ||
| opts.rooms.forEach(function(room) { | ||
| var chnRoom = chn + room + '#'; | ||
| var chnRoom = chn + room; |
Member
There was a problem hiding this comment.
Could you please update this part, to match https://github.com/socketio/socket.io-redis/blob/5.0.0/index.js#L407 (related: socketio/socket.io-redis-adapter#151)?
index.js
Outdated
| var parser = require('socket.io-parser'); | ||
| var hasBin = require('has-binary'); | ||
| var msgpack = require('msgpack-lite'); | ||
| var notepack = require('notepack.io'); |
Member
There was a problem hiding this comment.
Since notepack is just another msgpack implementation, how about keeping the var msgpack here?
Contributor
Author
There was a problem hiding this comment.
It looks like a wise choice! like socket.io-redis (https://github.com/socketio/socket.io-redis/blob/master/index.js#L8)
Removed, hasBinary package. Fix, socketIo multiroom event.
darrachequesne
approved these changes
May 12, 2017
Member
|
@v4l3r10 great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…keti.io-redis)
Fix, removed old namespace tag
Update dependencies