Skip to content

Conversation

@omrilitov
Copy link
Contributor

Hi,
I added an option named subEvent, so we could supply an ioredis client by providing the proper event as discussed here #60.

With this option we could use ioredis directly which would be great as it's a well deserved redis client.

@darrachequesne
Copy link
Member

LGTM 👍

@nkzawa @rauchg what do you think?

@rauchg rauchg merged commit e8e8b01 into socketio:master Apr 3, 2016
@plantain-00
Copy link

I think this is a really nice feature.
How/When can I get this from npm?
What about a new release of socket.io-redis?

@plantain-00
Copy link

FI, If can't wait the next release, npm install --save https://github.com/socketio/socket.io-redis

@acuervof
Copy link

+1 for new release

@artofspeed
Copy link

Hi, with this new commit, can anyone tell me how do I exactly pass in an io-redis instance? Thank you very much!

@omrilitov
Copy link
Contributor Author

@artofspeed Just pass messageBuffer as the subEvent option, and you'll be able to use an ioredis instance in the pubClient/subClient.
But this commit isn't out yet, we are still waiting for a new release

@darrachequesne darrachequesne added this to the 1.1.0 milestone Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants