Skip to content

Don't process socket.connect() if we are already re-connecting. #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Don't process socket.connect() if we are already re-connecting. #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/io/socket/client/Manager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ public Manager reconnection(boolean v) {
return this;
}

public boolean isReconnecting() {
return reconnecting;
}

public int reconnectionAttempts() {
return this._reconnectionAttempts;
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/socket/client/Socket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public Socket open() {
EventThread.exec(new Runnable() {
@Override
public void run() {
if (Socket.this.connected) return;
if (Socket.this.connected || Socket.this.io.isReconnecting()) return;

Socket.this.subEvents();
Socket.this.io.open(); // ensure open
Expand Down