Add support for getting clients in a given room #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2014
|
👍 |
dbrugne
added a commit
to dbrugne/donut
that referenced
this pull request
Jul 3, 2014
…will not work in multi-node environment. Fix: http://stackoverflow.com/questions/23858604/how-to-get-rooms-clients-list-in-socket-io-1-0 Request: socketio/socket.io#1428 Pull requests: - socketio/socket.io#1630 - socketio/socket.io-adapter#5 - socketio/socket.io-redis-adapter#15
|
Someone should merge this. |
This was referenced Oct 2, 2014
returns rooms the socket is in returns all rooms if no socket id is passed in
added roomClients method
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function in the base adapter for getting ids of connected clients in a room.
The function is async to allow simple replacement with the redis adapter (see pull request in socket.io-redis):
(socketio/socket.io-redis-adapter#15)
Also added mocha tests for all functions in adapter.js