Skip to content

Add support for new authentication type - PAT with external session ID #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 24, 2025
Merged

Add support for new authentication type - PAT with external session ID #2355

merged 6 commits into from
Jun 24, 2025

Conversation

@sfc-gh-saroskar
Copy link
Contributor

@sfc-gh-saroskar sfc-gh-saroskar commented Jun 12, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2096721

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

DB sec enabled new authentication type - PAT with external session ID - for Snowflake Accelerated Spark project. This PR adds support for it in Python connector.

  1. (Optional) PR for stored-proc connector:

DO_NOT_PORT_CHANGES_TO_SP

DO_NOT_PORT_CHANGES_TO_SP

sfc-gh-mmishchenko
sfc-gh-mmishchenko approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sfc-gh-saroskar sfc-gh-saroskar added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Jun 12, 2025
@sfc-gh-mmishchenko sfc-gh-mmishchenko force-pushed the saroskar-SNOW-2096721-pat-external-session branch from 0ba2468 to 210b480 Compare June 16, 2025 12:33
@sfc-gh-saroskar sfc-gh-saroskar force-pushed the saroskar-SNOW-2096721-pat-external-session branch from 210b480 to 71e468f Compare June 23, 2025 23:04
@sfc-gh-saroskar sfc-gh-saroskar merged commit cef7b51 into main Jun 24, 2025
95 of 98 checks passed
@sfc-gh-saroskar sfc-gh-saroskar deleted the saroskar-SNOW-2096721-pat-external-session branch June 24, 2025 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-saroskar @sfc-gh-mmishchenko