max-height/offsetHeight Calculation Issue, Fixes #2581 #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2581
If the number of items in the dropdown >
this.options.size, then the following line runs:menuHeight = liHeight * this.options.size + divLength * divHeight + menuPadding.vert;However,
liHeightis calculated wrong if the first item is hidden or if first item has text of''.Before adding the temporary
newElementto thebodyto calculate height, I always show the first item (I didn't check to see if hidden), and if first items text ='', I set it to (probably wouldn't need a check here either).Have created a new branch/commit for previous attempt at PR. Was able to run grunt lint successfully.
Original PR with some commentary about lint issues